Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Issue 554 - ValueError: cannot convert float NaN to integer #555

Closed
wants to merge 1 commit into from

Conversation

tswsxk
Copy link

@tswsxk tswsxk commented May 23, 2024

Description

Fixes #554

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Change line 196 from:

 if std != 0:
    digit = max(round(log10(1 / std) + 1) + 2, 0)
    self.round_dataframe[col] = self.dataframe[col].map(f"{{:.{digit}f}}".format).astype(float)

to

 if std != 0 and not pd.isna(std):
    digit = max(round(log10(1 / std) + 1) + 2, 0)
    self.round_dataframe[col] = self.dataframe[col].map(f"{{:.{digit}f}}".format).astype(float)

Test Configuration:

  • OS: CentOS Linux release 8.2.2.2004
  • Python version: python3.10
  • Shapash version: shapash-2.5.0

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@tswsxk tswsxk changed the title [fix] ValueError: cannot convert float NaN to integer [fix] Issue 554 - ValueError: cannot convert float NaN to integer May 23, 2024
@guillaume-vignal
Copy link
Collaborator

Thanks @tswsxk for your PR, the issue has been fixed with #553.
Don't hesitate to test the new version 2.6.0 of Shapash and tell us if everything is good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] ValueError caused by column with nan values
2 participants