News image description #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mainly happens when registering for an event while developing on a personal machine.
Previously, on the deployment server, the requests were always marked as insecure, resulting in e.g. `request.scheme` being "http". This was motivated by Facebook not showing the image of an article that was embedded in a post (https://www.facebook.com/MAKENTNU/posts/701447270512461), which was (most likely) caused by the `og:image` meta tag (in the `<head>` tag of `base.html`) specifying an image URL with "http" instead of "https" (because of `request.scheme`, as mentioned above).
Codecov Report
@@ Coverage Diff @@
## dev #401 +/- ##
==========================================
- Coverage 82.74% 82.72% -0.03%
==========================================
Files 117 117
Lines 4150 4161 +11
==========================================
+ Hits 3434 3442 +8
- Misses 716 719 +3
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an
image_descriptionfield to articles and events (which is inserted into thealtattribute of the<img>tags), which is useful for people using screen readers. It's also useful if the images don't load (for whatever reason), in which case the image description will be displayed instead.Additionally, a few minor changes: