Skip to content

Conversation

sbryngelson
Copy link
Member

@sbryngelson sbryngelson commented Aug 6, 2025

User description

Codecov improvement


PR Type

Other


Description

  • Fix typo in comment: "frqeuency" to "frequency"

  • Improve comment formatting and punctuation consistency

  • Update codecov configuration with strict YAML branch and max report age settings


Diagram Walkthrough

flowchart LR
  A["Code Comments"] -- "typo fixes" --> B["Improved Documentation"]
  C["Codecov Config"] -- "add settings" --> D["Enhanced Coverage Reporting"]
Loading

File Walkthrough

Relevant files
Documentation
m_constants.fpp
Fix typos and improve comment formatting                                 

src/common/m_constants.fpp

  • Fix typo in comment: "frqeuency" to "frequency"
  • Improve comment formatting and spacing consistency
  • Fix punctuation in author names comment
+4/-4     
Configuration changes
codecov.yml
Update codecov configuration settings                                       

.github/codecov.yml

  • Add strict_yaml_branch: default configuration
  • Add max_report_age: off setting
+2/-0     

@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 14:13
@sbryngelson sbryngelson requested a review from a team as a code owner August 6, 2025 14:13
@qodo-merge-pro qodo-merge-pro bot changed the title Improve codecov Improve codecov Aug 6, 2025
Copy link

qodo-merge-pro bot commented Aug 6, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR includes minor improvements to code quality by fixing spelling errors in comments and enhancing codecov configuration. The changes focus on documentation clarity and test coverage reporting settings.

Key changes:

  • Fixed spelling errors in parameter documentation comments
  • Updated codecov configuration to disable strict YAML branch checking and report age limits

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/common/m_constants.fpp Fixed spelling errors in comments for broadband spectral level parameter and algorithm reference
.github/codecov.yml Added configuration options to improve codecov reporting flexibility

integer, parameter :: mapCells = 3 !< Number of cells around the bubble where the smoothening function will have effect
real(wp), parameter :: R_uni = 8314._wp ! Universal gas constant - J/kmol/K
integer, parameter :: mapCells = 3 !< Number of cells around the bubble where the smoothening function will have effect
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant - J/kmol/K
Copy link
Preview

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment format is inconsistent. Based on the coding guidelines, comments should follow a consistent format. The unit specification should use consistent spacing and formatting like other parameter comments in the file.

Suggested change
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant - J/kmol/K
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant (J/kmol/K)

Copilot uses AI. Check for mistakes.

Copy link

qodo-merge-pro bot commented Aug 6, 2025

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use actual branch name

The strict_yaml_branch setting should specify an actual branch name rather than
"default". Consider using "main" or your primary branch name to ensure codecov
validates against the correct branch's configuration.

.github/codecov.yml [1-3]

 coverage:
-  strict_yaml_branch: default
+  strict_yaml_branch: main
   max_report_age: off
Suggestion importance[1-10]: 6

__

Why: The suggestion correctly points out that default is likely not the intended branch name for the strict_yaml_branch setting, and proposing main is a sensible improvement for the Codecov configuration.

Low
  • More

Copy link

codecov bot commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@9fbc566). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #977   +/-   ##
=========================================
  Coverage          ?   43.23%           
=========================================
  Files             ?       70           
  Lines             ?    20109           
  Branches          ?     2516           
=========================================
  Hits              ?     8695           
  Misses            ?     9877           
  Partials          ?     1537           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbryngelson sbryngelson merged commit 8173368 into MFlowCode:master Aug 7, 2025
28 of 33 checks passed
@sbryngelson sbryngelson deleted the coverage branch August 10, 2025 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant