-
Notifications
You must be signed in to change notification settings - Fork 117
Improve codecov #977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve codecov #977
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR includes minor improvements to code quality by fixing spelling errors in comments and enhancing codecov configuration. The changes focus on documentation clarity and test coverage reporting settings.
Key changes:
- Fixed spelling errors in parameter documentation comments
- Updated codecov configuration to disable strict YAML branch checking and report age limits
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
src/common/m_constants.fpp |
Fixed spelling errors in comments for broadband spectral level parameter and algorithm reference |
.github/codecov.yml |
Added configuration options to improve codecov reporting flexibility |
integer, parameter :: mapCells = 3 !< Number of cells around the bubble where the smoothening function will have effect | ||
real(wp), parameter :: R_uni = 8314._wp ! Universal gas constant - J/kmol/K | ||
integer, parameter :: mapCells = 3 !< Number of cells around the bubble where the smoothening function will have effect | ||
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant - J/kmol/K |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The comment format is inconsistent. Based on the coding guidelines, comments should follow a consistent format. The unit specification should use consistent spacing and formatting like other parameter comments in the file.
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant - J/kmol/K | |
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant (J/kmol/K) |
Copilot uses AI. Check for mistakes.
PR Code Suggestions ✨Explore these optional code suggestions:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #977 +/- ##
=========================================
Coverage ? 43.23%
=========================================
Files ? 70
Lines ? 20109
Branches ? 2516
=========================================
Hits ? 8695
Misses ? 9877
Partials ? 1537 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
User description
Codecov improvement
PR Type
Other
Description
Fix typo in comment: "frqeuency" to "frequency"
Improve comment formatting and punctuation consistency
Update codecov configuration with strict YAML branch and max report age settings
Diagram Walkthrough
File Walkthrough
m_constants.fpp
Fix typos and improve comment formatting
src/common/m_constants.fpp
codecov.yml
Update codecov configuration settings
.github/codecov.yml
strict_yaml_branch: default
configurationmax_report_age: off
setting