Skip to content

Improve codecov #977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2025
Merged

Improve codecov #977

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
888708c
Update codecov.yml
sbryngelson Aug 6, 2025
78da878
Update m_constants.fpp
sbryngelson Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/codecov.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
coverage:
strict_yaml_branch: default
max_report_age: off
status:
project:
default:
Expand Down
8 changes: 4 additions & 4 deletions src/common/m_constants.fpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module m_constants
real(wp), parameter :: acoustic_spatial_support_width = 2.5_wp !< Spatial support width of acoustic source, used in s_source_spatial
real(wp), parameter :: dflt_vcfl_dt = 100._wp !< value of vcfl_dt when viscosity is off for computing adaptive timestep size
real(wp), parameter :: broadband_spectral_level_constant = 20._wp !< The constant to scale the spectral level at the lower frequency bound
real(wp), parameter :: broadband_spectral_level_growth_rate = 10._wp !< The spectral level constant to correct the magnitude at each frqeuency to ensure the source is overall broadband
real(wp), parameter :: broadband_spectral_level_growth_rate = 10._wp !< The spectral level constant to correct the magnitude at each frequency to ensure the source is overall broadband

! Reconstruction Types
integer, parameter :: WENO_TYPE = 1 !< Using WENO for reconstruction type
Expand All @@ -59,14 +59,14 @@ module m_constants
real(wp), parameter :: initial_distance_buffer = 1.e12_wp !< Initialized levelset distance for the shortest path pair algorithm

! Lagrange bubbles constants
integer, parameter :: mapCells = 3 !< Number of cells around the bubble where the smoothening function will have effect
real(wp), parameter :: R_uni = 8314._wp ! Universal gas constant - J/kmol/K
integer, parameter :: mapCells = 3 !< Number of cells around the bubble where the smoothening function will have effect
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant - J/kmol/K
Copy link
Preview

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The comment format is inconsistent. Based on the coding guidelines, comments should follow a consistent format. The unit specification should use consistent spacing and formatting like other parameter comments in the file.

Suggested change
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant - J/kmol/K
real(wp), parameter :: R_uni = 8314._wp !< Universal gas constant (J/kmol/K)

Copilot uses AI. Check for mistakes.


! Strang Splitting constants
real(wp), parameter :: dflt_adap_dt_tol = 1.e-4_wp !< Default tolerance for adaptive step size
integer, parameter :: dflt_adap_dt_max_iters = 100 !< Default max iteration for adaptive step size

! Constants of the algorithm described by Heirer, E. Hairer S.P.Nørsett G. Wanner, Solving Ordinary Differential Equations I, Chapter II.4
! Constants of the algorithm described by Heirer, E. Hairer, S. P.Nørsett, G. Wanner, Solving Ordinary Differential Equations I, Chapter II.4
! to choose the initial time step size for the adaptive time stepping routine
real(wp), parameter :: threshold_first_guess = 1.e-5_wp
real(wp), parameter :: threshold_second_guess = 1.e-15_wp
Expand Down
Loading