Travisbeantest #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatandromeda
approved these changes
Jan 8, 2018
Owner
thatandromeda
left a comment
thatandromeda
left a comment
There was a problem hiding this comment.
Assuming that the answer to my question is "yes", and you've verified that this setup causes a deploy to happen (e.g. that the hashes in the requirements.txt file don't make anything blow up), go ahead and merge. Otherwise let's talk :)
| - DJANGO_DB_USER=postgres | ||
| - DJANGO_SETTINGS_MODULE=hamlet.settings.test | ||
| before_deploy: | ||
| - rm -rf hamlet/testmodels/ |
Owner
There was a problem hiding this comment.
Just to clarify, this happens on Travis's clone of the code and not on master?
| - DJANGO_SETTINGS_MODULE=hamlet.settings.test | ||
| before_deploy: | ||
| - rm -rf hamlet/testmodels/ | ||
| - pipenv lock --requirements > requirements.txt |
Owner
There was a problem hiding this comment.
Oh, cool, this is a sweet way to handle the requirements.txt problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.travis.yaml
Merge this before doing any deploys! I'm deleting the old environment (Hamtest) although I did like the name...