Refactor upload #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2018 15:42
The first 1024 bytes should be enough for magic to determine file type, at least for plain text and docx.
Iterating through byte chunks may split in the middle of words, or worse, the middle of multi-byte characters. Django's file object allows iterating by line which should be safer. Additionally, this explicitly decodes from UTF-8. This is probably fine for now, but we'll want to add encoding detection at a later point.
| for chunk in doc.chunks(): | ||
| bag_of_words.extend(str(chunk).strip().split(' ')) | ||
| for line in doc: | ||
| bag_of_words.extend(line.decode('utf-8').strip().split()) |
Owner
There was a problem hiding this comment.
Do we have any particular guarantee that this is UTF-8?
Collaborator
Author
There was a problem hiding this comment.
No, since they are uploading whatever, it could be whatever. We'd need to use chardet or something to have any confidence in our encoding assumptions. We should probably a new ticket for this.
Collaborator
Author
There was a problem hiding this comment.
Though, in the absence of any other information, UTF-8 is as good a guess as any.
Owner
There was a problem hiding this comment.
A new ticket to confirm encoding is 🌈 . I used UnicodeDammit for that in solenoid and it was great.
thatandromeda
approved these changes
Feb 2, 2018
Owner
thatandromeda
left a comment
thatandromeda
left a comment
There was a problem hiding this comment.
Given the opening of that ticket, LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up a few parts of the file processing to ensure we're handling bytes/strings appropriately.