Implement news theme templates #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-bernhardt
force-pushed
the
lm-143
branch
2 times, most recently
from
d9a86f5 to
444942c
Compare
matt-bernhardt
pushed a commit
that referenced
this pull request
May 10, 2023
* break out the conditional to be more explicit this if statement was failing when it was all on one line. Breaking it out has the result of actually accomplishing what is intended in the code * fix skip check previously we were skipping everything * fixes an unbound variable error * accept incoming code from cherry pick * Be explicit in our check vs $skip Co-authored-by: Phil Tyler <philip@tylerdigital.com> --------- Co-authored-by: Phil Tyler <philip@tylerdigital.com>
matt-bernhardt
pushed a commit
that referenced
this pull request
May 10, 2023
* break out the conditional to be more explicit this if statement was failing when it was all on one line. Breaking it out has the result of actually accomplishing what is intended in the code * fix skip check previously we were skipping everything * fixes an unbound variable error * accept incoming code from cherry pick * Be explicit in our check vs $skip Co-authored-by: Phil Tyler <philip@tylerdigital.com> --------- Co-authored-by: Phil Tyler <philip@tylerdigital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)