Initial News theme templating #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - Page templates going into a templates/ directory - Base templates staying at the theme root - inc/ and lib/ folders holding partials and internal libraries - The definition of the excerpt() function in functions.php There are no code changes through this commit - this is copy-paste only, although as noted above some files are now in a new location.
The changes here should be solid - I've come to trust PHPCBF's processes. Most of the changes are likely for whitespace issues, like fixing code indenting and spacing requirements.
There already is a "Bibliotech" template, and this one is properly named "News" (for now)
This will be removed more completely later, but for now I'm just commenting it out.
This also adds a root namespace slash to calls which need to stay in the root namespace. Some page templates are not affected by this change, because I haven't seen them get called yet.
|
@JPrevost I've tagged you for code review, to start the conversation about this change with an ability to see what it is. I see that GitHub Actions and CodeClimate are freaking about about this, and there is technical debt still to be resolved. If you'd prefer that I untag you and work on these flags, I'm happy to do so. I'm still working on the news theme, but am trying to prevent a ridiculously unwieldy PR. This may be too small a change, though, with this many issues remaining. |
JPrevost
approved these changes
Mar 28, 2023
This was referenced Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commits in this PR do the following:
inc/entry.php. No code is changed. The templates which Pages will use do move into a newtemplates/folder, similar to how the other themes are structured.cards.phppage-news.phpgetRootfunction at the top of some page templates. This will need to be more thoroughly cleaned in the next PR.Mitlib/Newsnamespace to any template that gets loaded when the production content gets imported.The goal of all of this is to bring in all the legacy PHP templates, and to make sure that the resulting theme doesn't crash egregiously after the current set of content is imported.
This PR will not close LM-143 entirely, but it does bring us close enough that I'll be able to import the production content in a review app, and closely inspect the behavior and resolve the rest of the issues.
Developer
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
NO dependencies are updated
Code Reviewer
(not just this pull request message)