-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dwi2mask overhaul (replacement PR) #2197
Conversation
Deleted C++ verison of dwi2mask Implemented python wrapper for dwi2mask Implemented first dwi2mask algorithm fslbet
dwi2mask initial overhaul
- dwi2mask hdbet: Utilises the "HD-BET" tool. - dwi2mask legacy: Python-based reproduction of MRtrix3 dwi2mask binary command. - dwi2mask template: Brain masking based on registration to a template image then transformation of a brain mask in template space back to the subject.
dwi2mask: Rob updates day1
- dwi2mask ants: New stand-alone algorithm that invokes antsBrainExtraction.sh (as was done in the previous version of dwi2mask template). - dwi2mask template with -software ants dow no longer invokes antsBrainExtraction.sh, and instead does a basic registration to template & inverse transformation of brain mask data.
dwi2mask: New algorithm "ants"
[ENH] dwi2mask template: Enhancements
Now includes content of Lestropie#2. Would like to merge and encourage more widespread evaluation prior to |
One other thing to confirm that nobody's unhappy with here is the naming of the additional |
Not sold on the 'bigblob' name - though it does have a certain appeal. Just a thought, but given its mode of operation and the intention behind it, might it not be more appropriate to make that available as an option within the connected component filter, simply by adding
would make sense? |
As long as Just need to think about what to do if the filling of one component results in inclusion of voxels that are already in another component (e.g. concentric shells), since that result can't be stored as an integer label image. |
So it turns out there's more gymnastics involved in adding a fill operation to the connected component algorithm than foreseen, the implementation code ends up branching between fill and not moreso than the overlap if wanting to support filling in the absence of So I think it in fact makes more sense to remove |
Requisite update for compatibility with cc02b18.
Mildly modified script output due to changes to mrhistmatch command in MRtrix3#2184.
Conflicts: cmd/dwi2mask.cpp core/filter/dwi_brain_mask.h
dwi2mask is now a Python script, and therefore does not support command-line piping.
dwi2mask template was renamed to dwi2mask b02template in cc02b18.
#2088 is broken due to me wiping my fork (completely forgetting that that's where the
dwi2mask
updates were...) and GitHub refusing to re-establish the PR link; so relisting.Given that the other OHBM Hackathon MRtrix3 project has matured to a preview release and should become a part of
3.1.0
, I wanted to clear this off of my desk; there's also been a couple of private discussion threads where having this finalised would be beneficial. Listing as a full PR rather than a draft in the hope of getting some fresh eyes & opinions on it, but I will probably try to make some test data before merging.There's some brain masking approaches that I tried to get working as a
dwi2mask
algorithm but couldn't get anything reasonable out of them, I still have the code if anyone wants to try themselves:https://github.com/GUR9000/Deep_MRI_brain_extraction
https://pypi.org/project/deepbrain/
I'm open to implementing further algorithms to wrap existing approaches, but such approaches need to be compatible with T2-weighted images, and many newer brain extraction approaches are T1w tailored.
Because it's coming from my fork I don't have things set up to preview the documentation, but you can see the relevant raw pages:
https://github.com/Lestropie/mrtrix3/blob/dwi2mask/docs/dwi_preprocessing/masking.rst
https://github.com/Lestropie/mrtrix3/blob/dwi2mask/docs/reference/commands/dwi2mask.rst
@jdtournier: I thought about having hyperlinks in the
dwi2mask
help pages to the new dedicated docs page on the topic. But this would require parallel gymnastics to those used for getting version-matched hyperlinks into the SH-related binaries prior to tagging. Want to do it anyway?Edit: If doing so, should also add links to the
dwi2response
docs page in thedwi2response
help pages.Tagging @wtsyeda and @RicardoRios46 so that they're aware of the progress given their contributions.