Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading a custom config is considered as changing map #3194

Closed
LuisGuenther opened this issue Jan 12, 2023 · 2 comments
Closed

Loading a custom config is considered as changing map #3194

LuisGuenther opened this issue Jan 12, 2023 · 2 comments
Assignees
@ViktoriaGordeevaVG
Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@LuisGuenther
Copy link
Contributor

Bug

Expected Behavior

Camera changes to custom view when custom view is loaded

Actual Behavior

Camera perspective of custom view is being ignored because of the active settings flag "reset camera when changing map".

Steps to Reproduce the Problem

  1. Load a map.
  2. Change the camera perspective.
  3. Save the custom configuration.
  4. Restart codecharta.
  5. Activate the "reset camera" flag in settings.
  6. Load the map.
  7. Load the custom configuration.

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.113.0
  • OS: Windows 11
  • Browser: Firefox
@LuisGuenther LuisGuenther added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. labels Jan 12, 2023
@ce-bo ce-bo added the priority:medium Set by PO label Jan 16, 2023
@ce-bo
Copy link
Collaborator

ce-bo commented Jan 16, 2023 •
edited
Loading

We should check if this is the reason why the camera position is not set correctly when applying a custom view.

@ce-bo ce-bo added priority:high Set by PO and removed priority:medium Set by PO labels Feb 8, 2023
@ChristianHuehn ChristianHuehn mentioned this issue Jul 12, 2024
Closed
7 tasks
@ViktoriaGordeevaVG ViktoriaGordeevaVG self-assigned this Aug 21, 2024
ViktoriaGordeevaVG pushed a commit that referenced this issue Aug 22, 2024
#3194 fix the bug with perspective camera state of custom config
fc60e21
ViktoriaGordeevaVG pushed a commit that referenced this issue Aug 22, 2024
#3194 fix the bug with perspective camera state of custom config
886d143
ViktoriaGordeevaVG pushed a commit that referenced this issue Aug 22, 2024
#3194 add changelog
b256425
@ViktoriaGordeevaVG ViktoriaGordeevaVG mentioned this issue Aug 22, 2024
Merged
6 tasks
ViktoriaGordeevaVG added a commit that referenced this issue Aug 23, 2024
@ViktoriaGordeevaVG
Bug/3194/camera perspective of custom view (#3698)
4ae17da 
* fix the bug with perspective camera state of custom config

* #3194 fix the bug with perspective camera state of custom config

* #3194 fix the bug with perspective camera state of custom config

* #3194 add changelog

---------

Co-authored-by: VictoriaG <victoria.gordeeva@maibornwolff.de>
@phanlezz
Copy link
Collaborator

Closed as completed through #3698

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ViktoriaGordeevaVG ViktoriaGordeevaVG

Labels
bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ce-bo @phanlezz @LuisGuenther @ViktoriaGordeevaVG