Skip to content

Conversation

twiest
Copy link

@twiest twiest commented May 25, 2014

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 806b5dd on twiest:fix_bug_97 into 4a31d40 on ManageIQ:master.

@cfme-bot
Copy link
Member

Checked commit https://github.com/twiest/linux_admin/commit/806b5ddc4ef6e73f440f89f98b60f573faa4c148 with rubocop 0.21.0
2 files checked, 1 offense detected

spec/disk_spec.rb

  • Style - Line 6, Col 76 - DotPosition - Place the . on the next line, together with the method name.

@Fryguy
Copy link
Member

Fryguy commented Jun 3, 2014

Can you squash your commits and change the title to describe the issue being fixed as opposed to just a reference to the bug? In addition, put a reference to the bug like Fixes #97 in the body of the commit.

Thanks for fixing this bug!

Fryguy pushed a commit to Fryguy/linux_admin that referenced this pull request Jul 9, 2014
@Fryguy Fryguy closed this in 924f3c4 Jul 10, 2014
jrafanie added a commit that referenced this pull request Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants