Ensure yum update raises on argument errors even with exit code 0 #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunne
force-pushed
the
ensure_yum_update_raises_on_error
branch
from
15b3c02 to
cb337ea
Compare
lib/linux_admin/yum.rb
Outdated
There was a problem hiding this comment.
This begs for a comment or something.
Does it make sense to use run and instead to make it obvious that yum in some cases is exiting 0 on errors:
raise ... if (out.exit_status != 0) || (out.exit_status == 0 && out.error.include?("No Match for argument"))There was a problem hiding this comment.
Forget if it's exit_code or exit_status....
There was a problem hiding this comment.
I'd rather get yum fixed and have it exit 1 and let run! handle it. I'll open a bug on yum and make a comment with the BZ id.
|
Good find. Just had a few small nitpicks. |
bdunne
force-pushed
the
ensure_yum_update_raises_on_error
branch
from
cb337ea to
a18b3e6
Compare
|
Checked commit bdunne@a18b3e6 with rubocop 0.21.0 spec/yum_spec.rb
|
|
@jrafanie updated based on your comments |
|
@brandondunne Looks good to me, merge at will when green. |
bdunne
added a commit
that referenced
this pull request
Sep 12, 2014
…_error Ensure yum update raises on argument errors even with exit code 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1136941