Added class for managing IP addresses #124
Conversation
lib/linux_admin/ip_addr.rb
Outdated
There was a problem hiding this comment.
I would not name this so similarly to the Ruby class. Maybe just spell it out (IpAddress)? Should it be part of a larger class like NetworkConfig or something?
There was a problem hiding this comment.
@Fryguy If we go the route of creating a larger class we would be able to add stuff like DNS servers to it rather than having a separate class for that, but in that case I would also want to move the functionality from https://github.com/ManageIQ/linux_admin/blob/master/lib/linux_admin/hosts.rb to the larger class. Is that a change we want to make to the API?
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
carbonin
force-pushed
the
add_ip_address_class
branch
from
dc2dd02 to
17c5d44
Compare
|
Checked commit carbonin@17c5d44 with ruby 1.9.3, rubocop 0.34.2, and haml-lint 0.13.0 |
Added class for managing IP addresses
Introduced in commit: 17c5d44, PR ManageIQ#124
4 participants
Added a class that currently allows retrieving IP addresses via
hostname -Iusing a retry mechanism.