Add Hardware#total_cores based on MiqSystem.num_cpus #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/linux_admin/hardware.rb
Outdated
bdunne
force-pushed
the
add_hardware_class
branch
from
493075c to
3d8ca72
Compare
|
@jrafanie Updated |
bdunne
force-pushed
the
add_hardware_class
branch
2 times, most recently
from
712572d to
0f45430
Compare
https://github.com/ManageIQ/manageiq/blob/master/gems/pending/util/miq-system.rb#L48:L62 MiqSystem.num_cpus is incorrectly reporting cores, this is a more reliable solution
bdunne
force-pushed
the
add_hardware_class
branch
from
0f45430 to
6e55bf8
Compare
|
Checked commit bdunne@6e55bf8 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 spec/hardware_spec.rb
|
bdunne
changed the title
|
Looks good. |
jrafanie
added a commit
that referenced
this pull request
Jan 15, 2016
Add Hardware#total_cores based on MiqSystem.num_cpus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ManageIQ/manageiq/blob/master/gems/pending/util/miq-system.rb#L48:L62