Made Common its own class rather than a module #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carbonin
force-pushed
the
stop_using_common_as_a_mixin
branch
2 times, most recently
from
705d5a1 to
97f4aba
Compare
|
This makes sense to me. 👍 |
| allow(LinuxAdmin::VolumeGroup).to receive_messages(:run! => double(:output => "")) | ||
| allow(described_class).to receive_messages(:run! => double(:output => "")) | ||
| allow(LinuxAdmin::Common).to receive_messages(:run! => double(:output => "")) | ||
| allow(LinuxAdmin::Common).to receive_messages(:run! => double(:output => "")) |
There was a problem hiding this comment.
Do you need this twice? allow should handle any number of calls, right?
carbonin
force-pushed
the
stop_using_common_as_a_mixin
branch
from
97f4aba to
907c20b
Compare
Previously nearly all classes were mixing in LinuxAdmin::Common to get access to what really are just utility methods. Fixes ManageIQ#19
carbonin
force-pushed
the
stop_using_common_as_a_mixin
branch
from
907c20b to
9e7d113
Compare
|
Checked commit carbonin@9e7d113 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 spec/physical_volume_spec.rb
|
bdunne
added a commit
that referenced
this pull request
Feb 11, 2016
Made Common its own class rather than a module
carbonin
added a commit
to carbonin/manageiq
that referenced
this pull request
Feb 12, 2016
Required to use a linux_admin gem version containing the PR here ManageIQ/linux_admin#148 which removes access to the LinuxAdmin::Common module's methods through any class in LinuxAdmin.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously nearly all classes were mixing in LinuxAdmin::Common
to get access to what really are just utility methods.
Not sure when a good time to make this sort of change is, but I'm giving it a shot.
@bdunne @Fryguy @jrafanie
Fixes #19