add rubocop to Gemfile #153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gemfile
Outdated
| # Specify your gem's dependencies in linux_admin.gemspec | ||
| gemspec | ||
|
|
||
| gem 'rubocop' |
There was a problem hiding this comment.
@kbrock shouldn't this be in the gemspec as a development dependency?
There was a problem hiding this comment.
I can move.
I like these in Gemfile for some reason.
|
Checked commits kbrock/linux_admin@27a3b3a~...ce5bc17 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
thanks @bdunne is this good now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use bundle exec to run commands
The bot is running
rubocopson these. So, staterubocopas a dependency. (at least in the localGemfile)