trim down service calls and add mac support #154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbrock
force-pushed
the
service_refactor
branch
from
0ad7409 to
824d66b
Compare
|
regarding lint - is it safe to assume |
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
kbrock
force-pushed
the
service_refactor
branch
from
824d66b to
b4b0bf0
Compare
|
Checked commit kbrock@b4b0bf0 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 lib/linux_admin/service/brew_service.rb
|
|
<pr_mergeability_checker />This pull request is not mergeable. Please rebase and repush. |
|
Cleaning up loose ends. PR is way stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reduce duplicate code for
LinuxAdmin::Serviceadd support for the mac as well.
/cc @carbonin this is related to ManageIQ/manageiq#6208