flush out fstab.write

[movitto]

No description provided.

[coveralls]

Coverage increased (+0%) when pulling bb9473d on movitto:fstab_write into 42d0486 on ManageIQ:master.

[Fryguy]

Suggest using block format of File.open. However, I also noticed there's a write method in LinuxAdmin::Common. Should we be using that one? Does the possible method name conflict cause a problem? FWIW, I'm actually not a fan of that method in Common.

[jrafanie]

@movitto I wonder if we need to check if /etc/fstab is writable.

[jrafanie]

@movitto Maybe we should make a big fat TODO and create an issue here that we may need to edit/append to the existing file in the future. I can imagine someone having customizations in fstab that may get lost depending on what write does.

[movitto]

I wonder if we need to check if /etc/fstab is writable.

I'd assume that only users w/ superuser privs would be able to call fstab.write (as well as alot of other linux_admin functionality). We can make this explicit at some point, but affects more than this method / should be handled separately.

Maybe we should make a big fat TODO and create an issue here that we may need to edit/append to the existing file in the future.

FStab is a singleton class and in the constructor the entries are read from the filesystem. From that point, any calls to 'write' will include those entries.

[jrafanie]

My bad, I guess the idea is we'll add items to @entries and they'll automatically be written via the write! method.

[jrafanie]

👍