Create partition in disk

[movitto]

No description provided.

[coveralls]

Coverage increased (+0%) when pulling d45cfa0 on movitto:create_partition into bf07ddd on ManageIQ:master.

[Fryguy]

Suggest case statement instead of a complicated if

case fields[i]
when :start_sector, :end_sector, :size
  if val =~ /([0-9\.]*)([KMG])B/
    ...
  end
when :id
  val = val.to_i
end

[coveralls]

Coverage remained the same when pulling f8fee09 on movitto:create_partition into bf07ddd on ManageIQ:master.

[Fryguy]

Looks good to me. @jrafanie?

[jrafanie]

Minor nitpick: here we reference @Partitions and on line 74, 75, and 76 we reference partitions. I believe they're all referring to the same thing but here we access the instance variable directly whereas, the latter lines use the memoized partitions method. We should be consistent.

[jrafanie]

@movitto This looks awesome other than my minor nitpick above.

[coveralls]

Coverage increased (+0%) when pulling e294073 on movitto:create_partition into bf07ddd on ManageIQ:master.

[jrafanie]

@movitto Very nice. When pushing commit(s) in response to feedback from someone, please @ mention them to let them know your commits are up and ready for re-review/merge. Thanks!