Create a missing partition table before creating a partition.

[jrafanie]

No description provided.

[coveralls]

Coverage increased (+0.02%) when pulling 0b71b56 on jrafanie:create_partition_table_if_missing into 9f8d568 on ManageIQ:master.

[Fryguy]

Prefer String#include? to a Regex when not using anything Regex-y

[Fryguy]

As per my other note, this could be

def result_indicates_partition_table?(result)
  # parted exits with 1 but writes this oddly spelled error to stdout.
  missing = result.exit_status == 1 && result.output.include?("unrecognised disk label")
  !missing
end

EDIT: or

def result_indicates_partition_table?(result)
  # parted exits with 1 but writes this oddly spelled error to stdout.
  result.exit_status != 1 || !result.output.include?("unrecognised disk label")
end

[jrafanie]

@Fryguy I'll try it out and see what I like.

[jrafanie]

@Fryguy This is ready to go. I removed the negative logic and used include? over the regex.

@movitto This may conflict with the code you are looking at now. My changes are very specific so it should be easy to resolve. Ping me if you need help.

[coveralls]

Coverage increased (+0.02%) when pulling c38fa31 on jrafanie:create_partition_table_if_missing into 9f8d568 on ManageIQ:master.

[coveralls]

Coverage increased (+0.02%) when pulling c38fa31 on jrafanie:create_partition_table_if_missing into 9f8d568 on ManageIQ:master.