Code cleanup for code climate

[movitto]

No description provided.

[Fryguy]

Does this really belong in LinuxAdmin::Common? I'm thinking it might be better to have a Volume class that acts as a base class for LogicalVolume and PhysicalVolume.

[Fryguy]

Why were all of the described_class calls undone?

[coveralls]

Coverage increased (+0.18%) when pulling 849b27d on movitto:code-cleanup1 into 9f8d568 on ManageIQ:master.

[jrafanie]

@movitto Does it make sense to process each line in a method? You might have to splat the *process_volume_display_line.

def self.process_volume_display_line(line)
  fields = line.split(':')
  vgname = fields[1] 
  vg = vgs.find { |vg| vg.name == vgname }
  return fields, vg 
end

def self.scan_volumes(cmd)
  # ...
  out.each_line do |line|
    fields, vg = process_volume_display_line(line)
    lvs << yield(fields, vg)
  end

  lvs
end

[jrafanie]

@movitto This looks really good so far. As long as we bury the complicated logic like what 8-10 columns in a fstab line mean in a nicely named method, the callers don't have to care the order of those columns or if they are chomped, split, and String/Fixnums, etc.

[coveralls]

Coverage remained the same when pulling 76d6ec7 on movitto:code-cleanup1 into 9f8d568 on ManageIQ:master.

[movitto]

@jrafanie @Fryguy

• added volume subclass w/ suggested helper methods
• pulled out fstab entry processing to a FStabEntry.from_line helper method
• renamed get to read
• probably forgetting something :-)

[Fryguy]

This PR is not mergable, Please rebase and repush.

[movitto]

@jrafanie @Fryguy rebased

[coveralls]

Coverage increased (+0.18%) when pulling 3bf7ec0 on movitto:code-cleanup1 into 350b850 on ManageIQ:master.