Raise specific NoSuchFileError for missing files #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jrafanie please review |
|
I'm thinking if we decide to create a new Exception class it should derive from Errno::ENOENT, so callers can still catch that Exception. |
lib/linux_admin/common.rb
Outdated
There was a problem hiding this comment.
Suggest trimming up the whitespace on lines 27 and 31
lib/linux_admin/exceptions.rb
Outdated
There was a problem hiding this comment.
ETOOMANYMESSAGES...
It doesn't look like you care about the exception other than it's message. So, just pass in the message.
Strip params to avoid clear text passwords
Fryguy
added a commit
that referenced
this pull request
Aug 27, 2013
…le_or_directory_errors Raise specific NoSuchFileError for missing files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strip params to avoid clear text passwords