accept extents as option param in LogicalVolume#create

[movitto]

No description provided.

[coveralls]

Coverage increased (+0.01%) when pulling d42a52f on movitto:lvm-extents into a958afe on ManageIQ:master.

[jrafanie]

@movitto I'll test it out and let you know.

[Fryguy]

I'm not big on having the API for the values for size or extents to be the strings that parted would expect. As a caller, I would expect to pass something like 256.gigabytes to size and for extents one of: 100, '100%', or 100.percent (although I'm not sure that third one's a valid method)

[jrafanie]

Yeah, @movitto, after seeing @Fryguy's comment, I agree.

I like:

LogicalVolume.create 'lv', @vg, :extents => 100

and

LogicalVolume.create 'lv', @vg, :size => 256.gigabytes  # a Fixnum in bytes

It hides parted's implementation over something like this:

LogicalVolume.create 'lv', @vg, :extents => '100%FREE'
LogicalVolume.create 'lv', @vg, :size => '256G'

Both values should be variants of Fixnums and we can convert the extents to a percent string like:
100 => "100%FREE"

And size value to a parted size string:
256.gigabytes => "256G"

[coveralls]

Coverage decreased (-0.39%) when pulling f145268 on movitto:lvm-extents into a958afe on ManageIQ:master.

[movitto]

@jrafanie @Fryguy updated

[jrafanie]

@movitto Does it make sense to simplify this conditional by assuming if the 3rd argument is > 100, the number is a size, otherwise it's a percent?

def self.create(name, vg, value)
  ...
  if value <= 100
    params.merge!({'-l' => "#{value}%FREE"})
  else
    params.merge!({'-L' => bytes_to_string(value)})
  end
  ...
end

[coveralls]

Coverage decreased (-0.39%) when pulling b5a6802 on movitto:lvm-extents into 920fcbf on ManageIQ:master.

[movitto]

@jrafanie sounds good to me, updated