further parameterize disk#create_partition, accept params for % of free ...

[movitto]

...space

[coveralls]

Coverage increased (+0.03%) when pulling c58cb83 on movitto:create_partitions_percentages into 07a33b8 on ManageIQ:master.

[jrafanie]

This is called via parted_options_array for print, mklabel and mkpart but I believe -a opt is only valid for mkpart. I think the others will fail. This should be only done for mkpart l believe.

[coveralls]

Coverage remained the same when pulling f8f2902 on movitto:create_partitions_percentages into 07a33b8 on ManageIQ:master.

[coveralls]

Coverage remained the same when pulling f8f2902 on movitto:create_partitions_percentages into 07a33b8 on ManageIQ:master.

[movitto]

@jrafanie updated

[Fryguy]

spacing is funny here and on the next few lines...looks like it needs an extra space.

[coveralls]

Coverage decreased (-24.65%) when pulling 431b95d on movitto:create_partitions_percentages into 07a33b8 on ManageIQ:master.

[movitto]

@Fryguy updated

[Fryguy]

I just checked and Range#overlaps? and Range#include? are already provided by active_support and should be preferred over rolling our own.

[coveralls]

Coverage increased (+0.04%) when pulling 8b4cf01 on movitto:create_partitions_percentages into 11a950a on ManageIQ:master.

[bdunne]

Looks like you can get rid of the partition =

[movitto]

@brandondunne @Fryguy updated

Lines split up to keep them < 80 chars long. Relaxed that rule in the spec suite, but in the main lib would rather keep to that max-width as it's pretty standard

[bdunne]

Looks like the context should be around creating multiple partitions context "multiple partitions" do, then have it "with valid params" do and it "with overlapping params" do, what do you think?

[coveralls]

Coverage increased (+0.04%) when pulling b62ecdb on movitto:create_partitions_percentages into 11a950a on ManageIQ:master.

[movitto]

@brandondunne updated.