-
Notifications
You must be signed in to change notification settings - Fork 30
Add mechanism to lookup specific package information #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lib/linux_admin/deb.rb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer each_with_object over inject for modifying hashes like this so you don't have to care about returning the object at the end of the block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also suggest you process the line(s) in a method so you can write tests with lots of different input without having to call/stub apt-cache.
@jrafanie @Fryguy updated, here are my thoughts:
Shout out if anything else looks off / needs to be updated to make this in. |
|
Native package system lookup method for rpm and deb package systems are provided as well as an abstract mechanism so the user doesn't have to know distro details.
All good to me 👍. @Fryguy Did you have anything else before this is merged? |
@Fryguy indicates we're all good. |
Add mechanism to lookup specific package information
Native package system lookup method for rpm and deb
package systems are provided as well as an abstract
mechanism so the user doesn't have to know distro details