Move certificate installation to linux admin #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Call class methods with . over ::
|
The code looks duplicated across the two types. Can the method be moved down into a base class? |
|
@Fryguy Updated based on comments. The problem is that the method doesn't make sense in the base class because the base class is used when the system is not registered. |
|
@brandondunne That's a weird layout for the class inheritance, then. There should probably be an Unregistered class or something that lives alongside Rhn and SubscriptionManager. |
|
@Fryguy updated based on conversation |
Fryguy
added a commit
that referenced
this pull request
Nov 13, 2013
…n_to_linux_admin Move certificate installation to linux admin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.