Extract #run into awesome_spawn gem.

[Fryguy]

See https://github.com/ManageIQ/awesome_spawn .

[coveralls]

Coverage remained the same when pulling 4da970b on Fryguy:extract_run_into_awesome_spawn into 385ee8c on ManageIQ:master.

[Fryguy]

@brandondunne Please review.

[bdunne]

Looks good 👍

[bdunne]

@jrafanie Any concerns?

[jrafanie]

@brandondunne We need to cut a major version because it introduces a new dependency and the namespacing changed:

CommandResultError          -> AwesomeSpawn::CommandResultError
CommandResult               -> AwesomeSpawn::CommandResult
LinuxAdmin::NoSuchFileError -> AwesomeSpawn::NoSuchFileError

We'll need to add entry to the changelog in case anyone is referencing these classes directly.

When we're ready to merge this, we should cut a tag and change the version, changelog, etc.

[jvlcek]

@Fryguy Why did you change from :run to :run! ?

[Fryguy]

So the old specs were relying on an implementation detail of the old run code, specifically that run! called run. That is no longer the right assumption, so the tests were failing. I changed them to properly expect the method they are calling.

[jvlcek]

@Fryguy, Thanks for the replies. Looks good to me. More educational for me than anything...

[Fryguy]

@brandondunne What's left on this? This is going to have a conflict with #87 , hence why I'm asking

[bdunne]

@Fryguy Code-wise everything looks great. I think we just need to discuss merging it with @jrafanie. We may want to merge #87 (and a couple others) first.

[jrafanie]

Yeah, @Fryguy @brandondunne, let's get any nonbreaking changes in first, cut a patchlevel tag bump and then merge this and bump major/minor.

[Fryguy]

@brandondunne Going to change the awesome_spawn version since it has bumped since I started this PR...hold off on merge.

[Fryguy]

Ok, updated to latest awesome_spawn version and also changed Rpm.import_key spec to fall in line with the changes here.

[Fryguy]

yay! 🍔