Fix invalid chargeback factories #13310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Checked commits imtayadeway/manageiq@ebb7875~...295f6a4 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These factories do not pass factory girl's built-in linter because they follow an anti-pattern of defining an "abstract" factory from which one or more fixture-style factories inherit. This can lead to obscure/brittle tests. To remedy this, I've removed child factories and given the "abstract" factories everything they need to build a valid model. Then, in the test body, I've updated to specify the attributes that are being tested when the object gets built, making them IMO more readable.
@miq-bot add-label test, technical debt
@miq-bot assign @jrafanie