Relative imports #26
Merged
Relative imports #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
From my analysis, the only thing that could break here is the |
PgBiel
added
pr:bugfix
|
By "test" I mean just running a few scenes and making sure they don't break. I don't think this should wait until we get pytest or something similar working. |
|
Would running the sample scenes discussed in #22 be enough of a test to merge this? |
|
I verified that all of the sample scenes run and actually even found a few missed imports. It's tested enough for me. |
eulertour
commented
May 20, 2020
XorUnison
approved these changes
May 20, 2020
leotrs
approved these changes
May 21, 2020
naveen521kk
added a commit
that referenced
this pull request
Dec 31, 2020
* Use manimpango * Remove MarkUp Text not yet supported * add manimpango as dep * remove MarkupText from __all__ * Fix CairoText * Remove test for Pango * Run black * Update ManimPango * Try fixing MacOS CI by restricting version of grpc * Try fixing MacOS CI - 2 * Make MarkupText use manimpango (#26) * Update ManimPango * update manimpango * Remove pango installation docs * remove ffi workaround from Dockerfile * troubleshooting: new entry for manimpango, hint for update for old pango problems Co-authored-by: Philipp Imhof <52650214+PhilippImhof@users.noreply.github.com> Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts all of the absolute imports in manimlib into relative imports as described in #15.
This required moving get_module() from config.py to extract_scene.py in order to prevent the user's code from triggering imports from constants.py until after the directories were initialized.
I would highly recommend testing this PR with a few scenes.