Skip to content

Conversation

ChungLeeCN
Copy link
Contributor

@ChungLeeCN ChungLeeCN commented Dec 3, 2024

Add a delay parameter to the turn_animation_into_updater function to allow for more precise control over when the animation starts. This parameter allows us to perform more complex timeline control.

Overview: What does this pull request change?

Motivation and Explanation: Why and how do your changes improve the library?

Links to added or changed documentation pages

doc link of turn_animation_into_updater

Further Information and Comments

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Add a `delay` parameter to the `turn_animation_into_updater` function to allow for more precise control over when the animation starts. This parameter allows us to perform more complex timeline control.
Copy link
Member

@JasonGrace2282 JasonGrace2282 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Just left a small comment about wording :)

@JasonGrace2282 JasonGrace2282 added the new feature Enhancement specifically adding a new feature (feature request should be used for issues instead) label Dec 3, 2024
@JasonGrace2282 JasonGrace2282 enabled auto-merge (squash) December 3, 2024 13:55
@JasonGrace2282 JasonGrace2282 merged commit 263623e into ManimCommunity:main Dec 3, 2024
20 of 21 checks passed
JasonGrace2282 added a commit to JasonGrace2282/manim that referenced this pull request Dec 3, 2024
behackl pushed a commit to JasonGrace2282/manim that referenced this pull request Jan 19, 2025
behackl added a commit that referenced this pull request Jan 20, 2025
* First draft of Changelog for 0.19.0

* fix typos

* added 3967

* Add #4037

* Update count 97 -> 98

* Add #4039

* Add #3930 and #4044

* Add this PR to changelog

* Add small description to changelog

* Add #3924, #3951, and #4038

* Bump Manim version to 0.19.0

* Update CITATION.cff to be more consistent

* remove github-security[bot]

* Feedback + missing PRs

* add newly merged PRs

* added more details to highlights + breaking changes

* bump date

* sort PRs in breaking changes section and include 3964

* sort highlights section

* fix: add required configuration key in .readthedocs.yml

* Update docs/source/changelog/0.19.0-changelog.rst

---------

Co-authored-by: Benjamin Hackl <devel@benjamin-hackl.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Enhancement specifically adding a new feature (feature request should be used for issues instead)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants