Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: don't fail CI on congestion test failure #1053

Merged
merged 28 commits into from
Mar 28, 2023

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Mar 27, 2023

Description

Removes congestion test from normal cargo test
Adds an extra step that runs just this test and creates a comment on the PR with run status.
Will create ✅ if it succeeds and ⚠️ if it fails because the price is too low.
Will run on every run_tests invocation and update the comment with the most recent CI run result if the comment already exists.


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Adam Reif added 2 commits March 27, 2023 11:54
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added C-enhancement Category: An issue proposing an enhancement or a PR with one A-ci Area: Continuous Integration L-changed Log: Issues and PRs related to changes labels Mar 27, 2023
Adam Reif added 13 commits March 27, 2023 13:27
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
fix
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Manta-Network Manta-Network deleted a comment from github-actions bot Mar 27, 2023
Adam Reif added 3 commits March 27, 2023 16:29
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Adam Reif added 2 commits March 27, 2023 16:47
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Manta-Network Manta-Network deleted a comment from github-actions bot Mar 27, 2023
@Manta-Network Manta-Network deleted a comment from github-actions bot Mar 27, 2023
Adam Reif added 2 commits March 27, 2023 16:57
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Manta-Network Manta-Network deleted a comment from github-actions bot Mar 27, 2023
@Manta-Network Manta-Network deleted a comment from github-actions bot Mar 27, 2023
@Garandor Garandor changed the title don't fail CI on congestion test failure Minor: don't fail CI on congestion test failure Mar 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 27, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

Adam Reif added 4 commits March 27, 2023 17:14
Signed-off-by: Adam Reif <Garandor@manta.network>
fix
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor marked this pull request as ready for review March 27, 2023 22:18
Adam Reif added 2 commits March 27, 2023 17:20
Signed-off-by: Adam Reif <Garandor@manta.network>
fmt
Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor merged commit 928dcd7 into manta Mar 28, 2023
@Garandor Garandor deleted the congestion_warning_comment branch March 28, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration C-enhancement Category: An issue proposing an enhancement or a PR with one L-changed Log: Issues and PRs related to changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants