Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup: Don't run PR commenting code on non-PRs #1056

Merged
merged 2 commits into from
Mar 31, 2023
Merged

Conversation

Garandor
Copy link
Contributor

@Garandor Garandor commented Mar 29, 2023

The change from #1053 failed on manta branch after merge here https://github.com/Manta-Network/Manta/actions/runs/4545751333/jobs/8013502359#step:11:46

Signed-off-by: Adam Reif Garandor@manta.network

Description


Before we can approve this PR for merge, please make sure that all the following items have been checked off:

  • Connected to an issue with discussion and accepted design using zenhub "Connect issue" button below
  • Added one label out of the L- group to this PR
  • Added one or more labels from the A- and C- groups to this PR
  • Explicitly labelled A-calamari, A-dolphin and/or A-manta if your changes are meant for/impact either of these (CI depends on it)
  • Re-reviewed Files changed in the Github PR explorer.

Situational Notes:

  • If adding functionality, write unit tests!
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Adam Reif <Garandor@manta.network>
@Garandor Garandor added A-ci Area: Continuous Integration L-fixed Log: Issues and PRs related to bug fixes L-skip Log: Will be skipped on changelog generation C-bug Category: Issues documenting a bug and removed L-fixed Log: Issues and PRs related to bug fixes labels Mar 29, 2023
@github-actions
Copy link

github-actions bot commented Mar 29, 2023

⚠️ Congestion test: 1-day congestion cost (calamari) is NOT above target_daily_congestion_cost_kma

@Garandor Garandor merged commit fa3d262 into manta Mar 31, 2023
@Garandor Garandor deleted the garandor/dont-fail-ci branch March 31, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration C-bug Category: Issues documenting a bug L-skip Log: Will be skipped on changelog generation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants