Skip to content

Conversation

@ronenkapelian
Copy link
Contributor

Improve seed process logs interpretation + BI + errors

Question Answer
Bug fix
New feature
Breaking change
Deprecations
Documentation
Tests added
Chore
  1. Use stream pipelines to handler cmd data instead of for await.
  2. Add wrap that can able detect and handler process errors that was crashed the Node on beta version of seeder.
  3. translate cli stdout into INFO and ERROR logs + evenets:
    a. Print only progress logs as info (by regex - "( /d tiles)".
    b. Catch seed errors by detecting logs (by regex " - ERROR - ") and failed as design.
  4. test coverage unfortentaly was decrised :'(
    :(
    becouse of zx mocking + process mocking complexity

@ronenkapelian ronenkapelian self-assigned this Feb 14, 2024
@ronenkapelian ronenkapelian changed the title fix: extend zx logs BI + generating real process errors fix: extend zx logs BI + generating real process errors (MAPCO-3950) Feb 14, 2024
Copy link

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, thanks! 🥇

Copy link

@asafMasa asafMasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ronenkapelian ronenkapelian merged commit 0e46007 into master Feb 18, 2024
@ronenkapelian ronenkapelian deleted the fix-zx-error-handler branch February 18, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants