Move some timeline fns from Coordinator to Catalog #33335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antiguru
reviewed
Aug 18, 2025
src/adapter/src/catalog.rs
Outdated
| let builtin_table_updates = self.state.apply_updates(updates)?; | ||
| Ok(builtin_table_updates) | ||
| } | ||
|
|
There was a problem hiding this comment.
Nit: The catalog.rs file is already very large, so I think it'd make sense to have it split across several files. This seems like an opportunity to do so?
There was a problem hiding this comment.
Yeah, I'd say we can create a new module catalog/timeline and move the methods there. Wdyt?
There was a problem hiding this comment.
Btw., I've split off only the newly moved code now, but should I try to split off more stuff into separate files in a follow-up PR? Ideas:
CatalogPlansand related methods (~200 lines)- expression cache stuff
ExprHumanizer(~150 lines)ConnCatalog- ...
aljoscha
approved these changes
Aug 19, 2025
ggevay
force-pushed
the
move-timeline-things-to-catalog
branch
from
a58c0b8 to
c9660fb
Compare
ggevay
force-pushed
the
move-timeline-things-to-catalog
branch
from
c9660fb to
55f756a
Compare
|
Merging! Can do more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works towards the Small Coordinator vision, specifically https://github.com/MaterializeInc/database-issues/issues/9593
These methods don't need to be on
Coordinator, because they only work with theCatalog. This PR moves them toCatalog, making them easier to call outside theCoordinator.This PR is purely code movement, no behavior change should happen from it.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.