Do least_valid_read
on ReadHolds
instead of Catalog
#33336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
least_valid_read
doesn't need access to anyCatalog
state; it can be done simply onReadHolds
. This PR modifies all call sites ofCatalog::least_valid_read
to instead callReadHolds::least_valid_read
directly, and deletesCatalog::least_valid_read
. This makes the code at these call sites easier to use from outside the Coordinator, and thus works towards the Small Coordinator vision, specifically https://github.com/MaterializeInc/database-issues/issues/9593.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.