-
Notifications
You must be signed in to change notification settings - Fork 480
terraform test: Try applying orchestratord version #33748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bobbyiliev
merged 16 commits into
MaterializeInc:main
from
bobbyiliev:pr-terraform-fix-orchestratord-version
Oct 4, 2025
+66
−3
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
16ca134
terraform test: Try applying orchestratord version
bobbyiliev c25bd93
terraform test: override operator image tag
bobbyiliev 3cdef2e
terraform test: override default helm values
bobbyiliev d89b881
terraform test: use correct version in helm yaml
bobbyiliev 86a84f0
terraform test: add more debugging info
bobbyiliev 2b26f67
terraform test: fix typo in workflow
bobbyiliev f0fadbc
terraform test: fix typo in workflow
bobbyiliev 1816e73
terraform test: add more debugging info
bobbyiliev e5d0a47
terraform test: add a small delay
bobbyiliev 62236c4
terraform test: add logs output
bobbyiliev 731e30f
terraform test: add 120s sleep for envd to boot
bobbyiliev e0c8015
terraform test: reduce to 30s sleep for envd to boot
bobbyiliev af37892
terraform test: select only first balancerd pod
bobbyiliev 91396e1
terraform test: fix lint
bobbyiliev b11e5f7
terraform test: select only first balancerd pod
bobbyiliev ce01127
terraform test: remove unused pod describe
bobbyiliev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -380,12 +380,51 @@ def kubectl_setup( | |
time.sleep(1) | ||
else: | ||
raise ValueError("Never completed") | ||
# Give the pods a chance to start and then check: | ||
time.sleep(30) | ||
for i in range(240): | ||
try: | ||
time.sleep(2) | ||
spawn.runv( | ||
["kubectl", "get", "pods", "-n", "materialize-environment"], | ||
cwd=self.path, | ||
) | ||
pod_names = spawn.capture( | ||
[ | ||
"kubectl", | ||
"get", | ||
"pods", | ||
"-n", | ||
"materialize-environment", | ||
"-o", | ||
"jsonpath={.items[*].metadata.name}", | ||
], | ||
cwd=self.path, | ||
).strip() | ||
envd_pods = [p for p in pod_names.split() if "environmentd" in p] | ||
for pod in envd_pods: | ||
spawn.runv( | ||
[ | ||
"kubectl", | ||
"describe", | ||
"pod", | ||
pod, | ||
"-n", | ||
"materialize-environment", | ||
], | ||
cwd=self.path, | ||
) | ||
# Get the logs of the pod: | ||
spawn.runv( | ||
[ | ||
"kubectl", | ||
"logs", | ||
pod, | ||
"-n", | ||
"materialize-environment", | ||
], | ||
cwd=self.path, | ||
) | ||
Comment on lines
+417
to
+427
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The logs output is helpful, but it can get noisy. |
||
status = spawn.capture( | ||
[ | ||
"kubectl", | ||
|
@@ -562,10 +601,10 @@ def connect(self, c: Composition) -> None: | |
"-n", | ||
"materialize-environment", | ||
"-o", | ||
"jsonpath={.items[*].metadata.name}", | ||
"jsonpath={.items[0].metadata.name}", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixes:
|
||
], | ||
cwd=self.path, | ||
) | ||
).strip() | ||
# error: arguments in resource/name form must have a single resource and name | ||
print(f"Got balancerd name: {balancerd_name}") | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to specify all default args due to a merge issue on the Terraform module side.