-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NPM releases should create tags in the repo #28
Labels
enhancement
New feature or request
Comments
This was done manually for the previous release, this issue remains for the CI/CD integration for automatic tag pushing |
You just need to do `git push --tags`.
…On 11 June 2020 13:58:18 GMT+10:00, Robbie Cronin ***@***.***> wrote:
This was done manually for the previous release, this issue remains for
the CI/CD integration for automatic tag pushing
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#28 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
yeah, that's the command I've used, it seems to be showing up okay: https://github.com/MatrixAI/js-encryptedfs/releases/tag/v0.1.0 |
How would that work if the repo hasn't received your tags from your local repo?
…On 11 June 2020 14:36:42 GMT+10:00, Robbie Cronin ***@***.***> wrote:
yeah, that's the command I've used, it seems to be showing up okay:
https://github.com/MatrixAI/js-encryptedfs/releases/tag/v0.1.0
We can put `git push --tags` in the `gitlab-ci.yml` file I guess?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#28 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
Closing on account of migration to gitlab |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Furthermore we can integrate the pushing to the CI/CD pipeline.
However I'm not sure yet, since it's not every commit results in a release. It should activate only when we decide there should be a release.
We can leave it for manual execution for now.
Either way, I'm not sure if you have pushed up an npm release, because I don't see any git tags. Note that you must do
git push --tags
to do it.Should investigate how to do this automatically with the pipeline, Gitlab CI does have manual pipelines as well I remember.
The text was updated successfully, but these errors were encountered: