Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPM releases should create tags in the repo #28

Closed
CMCDragonkai opened this issue May 21, 2020 · 5 comments
Closed

NPM releases should create tags in the repo #28

CMCDragonkai opened this issue May 21, 2020 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@CMCDragonkai
Copy link
Member

Furthermore we can integrate the pushing to the CI/CD pipeline.

However I'm not sure yet, since it's not every commit results in a release. It should activate only when we decide there should be a release.

We can leave it for manual execution for now.

Either way, I'm not sure if you have pushed up an npm release, because I don't see any git tags. Note that you must do git push --tags to do it.

Should investigate how to do this automatically with the pipeline, Gitlab CI does have manual pipelines as well I remember.

@CMCDragonkai CMCDragonkai added the enhancement New feature or request label May 21, 2020
@robert-cronin
Copy link
Contributor

This was done manually for the previous release, this issue remains for the CI/CD integration for automatic tag pushing

@CMCDragonkai
Copy link
Member Author

CMCDragonkai commented Jun 11, 2020 via email

@robert-cronin
Copy link
Contributor

yeah, that's the command I've used, it seems to be showing up okay: https://github.com/MatrixAI/js-encryptedfs/releases/tag/v0.1.0
We can put git push --tags in the gitlab-ci.yml file I guess?

@CMCDragonkai
Copy link
Member Author

CMCDragonkai commented Jun 11, 2020 via email

@robert-cronin
Copy link
Contributor

Closing on account of migration to gitlab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants