-
Notifications
You must be signed in to change notification settings - Fork 3
Reloading EFS (iNodeMgr) state and introducing recursive directory options #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Final thing to do here is to add some testing in for recursively deleting directories |
Does that mean Btw remember to squash when the CI passes too. |
Yep |
e5ccac7
to
8283d1c
Compare
Regenerate the docs please. Then once merged on master.
|
30d7b2b
to
981e471
Compare
981e471
to
0b8c9f8
Compare
Nice. |
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will fix two issues:
mkdir
andmkdirp
(second is for recursively creating dirs) while there should really only be one functions with the option to recursively create a directoryTasks
mkdir
andmkdirp
functionality into one functionrmdir
Final checklist