Skip to content

Reloading EFS (iNodeMgr) state and introducing recursive directory options #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2021

Conversation

scottmmorris
Copy link
Contributor

@scottmmorris scottmmorris commented Oct 8, 2021

Description

This PR will fix two issues:

  • Reloading EFS State: Currently, if an EFS object is created and then a second EFS instance with the same arguments is created an error will be thrown about duplicate root iNodes. Instead, this should set the root iNode as the existing root iNode and proceed with no errors.
  • Recursive directory options: In removing a directory, there is currently no way to recursively delete a directory which will be fixed here. Also, there are currently two functions to create directories mkdir and mkdirp (second is for recursively creating dirs) while there should really only be one functions with the option to recursively create a directory

Tasks

  1. Merge mkdir and mkdirp functionality into one function
  2. Add functionality to recursively delete a directory in rmdir
  3. Allow EFS to be loaded with existing state
  4. Expand testing for recursively deleting a directory
  5. Expand basic tests for EFS state

Final checklist

  • Domain specific tests
  • Full tests
  • Updated inline-comment documentation
  • Lint fixed
  • Squash and rebased
  • Sanity check the final build

@scottmmorris scottmmorris added bug Something isn't working development Standard development labels Oct 8, 2021
@scottmmorris scottmmorris self-assigned this Oct 8, 2021
@scottmmorris
Copy link
Contributor Author

Final thing to do here is to add some testing in for recursively deleting directories

@CMCDragonkai
Copy link
Member

Does that mean mkdirp is gone?

Btw remember to squash when the CI passes too.

@scottmmorris
Copy link
Contributor Author

Yep mkdirp is gone I have merged the functionality into one mkdir function with a recursive option

@CMCDragonkai
Copy link
Member

Regenerate the docs please.

Then once merged on master.

npm version minor
npm run build
git push
git push --tags
npm publish --access public

@scottmmorris scottmmorris merged commit f9bf639 into master Oct 11, 2021
@scottmmorris scottmmorris deleted the recursive-delete-dir branch October 11, 2021 03:41
@CMCDragonkai
Copy link
Member

Nice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working development Standard development
Development

Successfully merging this pull request may close these issues.

2 participants