Skip to content

v1.5.4 — hardening release

Choose a tag to compare

@MechanicalCoderX MechanicalCoderX released this 27 Aug 05:52
· 117 commits to main since this release

Hardening release from a full adversarial pre-submission review (eight
independent lenses, every finding re-verified against the code). The one
user-visible behaviour change worth reading first: on enclosures where the
vendor's device slot numbering does not match the SES element index, Identify
now lights the correct bay
— previously it could light the wrong bay's LED
on such shelves (the KTN-STL3, where the two numberings coincide, was never
affected).

Fixed

  • Identify addresses bays through a device-slot→element-index map built
    from the enclosure's Additional Element Status page (already on the
    helper's read-only allow-list), cached per enclosure. The map is positional
    and guarded by page-integrity checks (misattribution tell-tales, element
    counts against the configuration page, printed-index offset consistency);
    a slot the page does not map unambiguously — or a page failing any check —
    is refused with a clear error instead of guessed at.
  • The SES configuration-page parser no longer mis-attributes a descriptor's
    element count and label when a type descriptor carries no text line (a
    normal sg_ses variant).
  • A seated drive that failed hard enough for the kernel to delete its block
    device now renders as failed, not as an empty bay: fault/Critical SES
    status is checked before the device-presence test.
  • Bay SAS addresses are joined on the AES device slot number instead of
    conflating element index with sysfs slot; when the mapping is unknown, no
    address is shown rather than possibly the wrong drive's.
  • A same-name disk swap can no longer wear the previous drive's ZFS/remote
    identity for a poll interval: remote records are dropped when serial/WWN
    disagree with the local identity.
  • Enclosure hardware I/O (discovery, slot reads — flock-guarded, up to 30 s)
    now runs in a worker thread instead of on the event loop, so a wedged
    shelf degrades the slot cache instead of stalling the whole HTTP surface
    including /healthz.
  • With the opt-in REST fallback enabled, transport and JSON-decode failures
    are contained as TrueNASError instead of escaping and starving the
    unrelated SES/SMART polls.
  • Health alerts are no longer lost to a transient webhook failure: a
    transition is committed only after the endpoint accepts it, and an
    undelivered one is retried until delivered or superseded, spaced per bay.
  • An expired Identify whose auto-clear hits a transient failure (helper
    restart, detached enclosure) is retried with bounded backoff instead of
    being dropped with the LED left lit; permanent failure is logged loudly.
  • Login rate limiting is thread-safe under concurrent requests, and a
    rate-limited login is answered 429 (matching change-password) instead
    of 401.
  • The chassis view maps SES statuses onto the full health scale —
    Critical/Unrecoverable show as failed, not flattened to a warning badge —
    and a failed sign-out now surfaces on the screen the user lands on (the
    login-screen notice — or the error banner when authentication is
    disabled) instead of being silently swallowed.

Added

  • Shelves that report drive bays as plain Device slot elements (SES type
    0x01) are now supported alongside Array device slot (0x17) for discovery,
    Identify and SAS addresses.
  • KTN_ALLOWED_HOSTS: optional Host-header allow-list closing DNS rebinding
    when running with authentication disabled (default: allow all, unchanged).
  • KTN_FORWARDED_ALLOW_IPS: trust X-Forwarded-Proto from a named reverse
    proxy so the session cookie's Secure flag survives TLS termination
    (default unchanged: localhost only).
  • Root helper: per-connection socket timeout (an idle client no longer pins
    a root-process thread), and the post-bind chown/chmod verifies via
    lstat that the path is a non-symlink socket before touching it.
  • Test coverage for the previously untested security core: the helper's
    request dispatcher, the production Identify write path (helper socket +
    SES command), and expired/tampered/unsigned session cookies — plus
    negative-path auth tests and new E2E flows.

Changed

  • The image applies Debian security point-releases at build time. Both
    base images stay digest-pinned, but Docker Hub rebuilds slim images on its
    own schedule, so a pinned digest can carry an already-fixed CVE for days —
    this release ships with the openssl fix for CVE-2026-14456, which the
    newest published digest still lacked.
  • Release workflows: single tag trigger with a concurrency group, latest
    only for the highest semver tag, third-party actions pinned to commit
    SHAs, and the arm64 image now passes the Trivy gate before publish.
  • Documentation truth pass: INSTALL-TRUENAS.md, SECURITY.md, ARCHITECTURE.md
    and the staged catalog package no longer carry pre-1.5.2 claims (writable
    /sys, AppArmor relaxation, the retracted "SG_IO counts as a write"
    rationale, the removed setgid-bit mechanism); SECURITY.md now documents
    six allow-listed read methods and the system.version fallback.