New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix retirement and insufficient contract deployment nags #752

Merged

NickAragua merged 1 commit into MegaMek:master from NickAragua:fix_incorrect_nagging_zero_payout

Jun 15, 2018

Member

NickAragua commented Jun 14, 2018

Fixes two issues:

Sometimes, a dead/retired guy's payout comes out as 0. Then, it never gets processed.
The nagging (and application of contract score penalty) for insufficient lance deployment on AtB contracts wasn't happening. Bet people will love this fix.

For #1, I simply made it so that the applyRetirement function does its thing if the payout is more than 0 OR if there are any retirees.

For #2, the deployment deficit was coming back as less than 0, so I made the function output match its apparent semantic meaning.


          fix retirement and insufficient contract deployment nags

045b0b2

NickAragua requested review from mkerensky and neoancient

June 14, 2018 02:16

neoancient approved these changes

View reviewed changes

NickAragua merged commit d5f84a3 into MegaMek:master

NickAragua deleted the fix_incorrect_nagging_zero_payout branch

June 15, 2018 20:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet