Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix account display width for large currency values #5570

Merged
merged 1 commit into from
Oct 21, 2018

Conversation

alextsg
Copy link
Contributor

@alextsg alextsg commented Oct 21, 2018

Fixes #5558
image

@alextsg alextsg force-pushed the i5558-account-display-width branch 5 times, most recently from cb4ea02 to 743c7bc Compare October 21, 2018 13:46
@kumavis
Copy link
Member

kumavis commented Oct 21, 2018

The problem with using the elipses is that i have no idea how many digits are in there
( tho im not sure what a better solution would be, given dynamic screen sizes )

@alextsg
Copy link
Contributor Author

alextsg commented Oct 21, 2018

If you hover over the element you can see the full value as a tooltip.

@kumavis kumavis merged commit 802df46 into MetaMask:develop Oct 21, 2018
@alextsg alextsg deleted the i5558-account-display-width branch October 21, 2018 14:59
@isace1978

This comment has been minimized.

@wbt
Copy link
Contributor

wbt commented Oct 21, 2018

Might it be possible to move the ellipses to the left a bit, so the least significant 3 digits (plus whatever to the right of the decimal is shown by default) is shown, per #5558? Then people can see more easily how much the balance went down after some long series of operations, in case they're using a private network to prepare something to be deployed on a network where ETH costs more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants