Skip to content

Conversation

russelarms
Copy link
Contributor

@russelarms russelarms commented Dec 21, 2020

Please have a look at our guidelines for contributions and consider the following before you submit the PR:

  • Has CHANGELOG.md been updated?
  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?
  • Did you check UI tests on the sample app? They are not executed on CI.

Description

The code coverage has been broken on Android since we bumped up the Gradle plugin version.
This PR:

  • Fixes the code coverage task
  • Adds and changes tests to reach 100% coverage
  • Removes unused methods (postOnUiThread & runIfEnabled)

Related PRs or issues

AB#84105

@russelarms russelarms force-pushed the fix/jacoco-coverage-report branch from b22c93a to b9c9415 Compare December 22, 2020 15:05
@russelarms russelarms marked this pull request as ready for review December 23, 2020 12:18
@MatkovIvan MatkovIvan merged commit c05b2ab into develop Dec 24, 2020
@MatkovIvan MatkovIvan deleted the fix/jacoco-coverage-report branch December 24, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants