Allow string enum in element access #18029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously literal union types were disallowed to improve errors by printing `boolean` instead of `true | false`. But string enums are literal union types that should be allowed, so now only booleans are disallowed.
ghost
reviewed
Aug 25, 2017
| // In the following we resolve T[K] to the type of the property in T selected by K. | ||
| const apparentObjectType = getApparentType(objectType); | ||
| if (indexType.flags & TypeFlags.Union && !(indexType.flags & TypeFlags.Primitive)) { | ||
| if (indexType.flags & TypeFlags.Union && !(indexType.flags & TypeFlags.Boolean)) { |
There was a problem hiding this comment.
Could you add a comment explaining that we are avoiding TypeFlags.Boolean here for stylistic reasons to ensure that we show boolean and not true in error messages? Might also want to link to keyofAndIndexedAccessErrors.errors.txt, which is the only test that fails (i.e., has slightly different error messages) if this check isn't here.
Booleans are not treated like other unions in order to skip straight to error reporting so that the error is reported with 'boolean' instead of 'true'.
ghost
approved these changes
Aug 28, 2017
mhegazy
approved these changes
Aug 28, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16760
Previously literal union types were disallowed to improve errors by printing
booleaninstead oftrue | false. But string enums are literal union types that should be allowed, so now only booleans are disallowed.