Update the luis-bot-es6 example for botbuilder 4.0.0-preview1.2 #291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Stevenic
reviewed
Jul 12, 2018
|
|
||
| // Continue current dialog | ||
| } else { | ||
| const res = await dc.continue() |
There was a problem hiding this comment.
const res = [](start = 20, length = 11)
Why are you capturing this? You don't do anything with it and honestly its not needed.
Stevenic
reviewed
Jul 12, 2018
| if (context.activity.type === 'conversationUpdate' && context.activity.membersAdded[0].name === 'Bot') { | ||
| // Welcome message here, bot will message you first | ||
| await context.sendActivity(`Hi! I'm a simple reminder bot. I can help add reminders, delete and show them.`); | ||
| return await context.sendActivity(`Hi! I'm a simple reminder bot. I can help add reminders, delete and show them.`); |
There was a problem hiding this comment.
return [](start = 12, length = 6)
You don't technically need the return here given your code.
Stevenic
reviewed
Jul 12, 2018
| const utterance = (context.activity.text || '').trim().toLowerCase(); | ||
|
|
||
| // Create dialog context | ||
| const dc = dialogs.createContext(context, state); |
There was a problem hiding this comment.
const dc = dialogs.createContext(context, state); [](start = 12, length = 49)
This isn't being setup correctly. Your not actually getting the state object and its kind of working because you're using JS. TypeScript would have given an error. Look at the dialog sample for how to properly get the state.
|
Closing this PR for now as we await additional fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes up some problems from changes to the botbuilder api.
Also removed .then / .catch statements in favour of await.