Feature request: that 'Local to Field' refactoring class in `rope` be exposed via the "Python Refactor"

[tonybaloney]

Requesting that 'Local to Field' refactoring class in rope be exposed via the "Python Refactor" commands in the plugin.

Being able to select a local variable and convert it into a class field with a single shortcut would be a very useful feature.

Have already raised #3825 with a starting implementation.

[tonybaloney]

@DonJayamanne it's a valid concern. The PR should include a test for a type annotated variable as a minimum.
I've been experimenting with rope on 3.7.1 and not hit any issues so far. But if there are issues, the however-many-million users this plugin has are sure to find them :-)

[tonybaloney]

@DonJayamanne I spoke too soon it's already a known issue : python-rope/rope#254

[tonybaloney]

@DonJayamanne it fails quite spectacularly within the rope library. I wonder what happens to some of the existing refactorings like extractMethod and extractVariable

[brettcannon]

Closing in favour of adding appropriate support in the language server.