New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VS Code icon is too transparent #33503

Closed
weinand opened this Issue Aug 30, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@weinand
Member

weinand commented Aug 30, 2017

ref #33272:

On "Elementary OS (linux), the VS Code icon shows up in the dock with "sublime fragility":

2017-08-30_12-09-19

@weinand weinand added the bug label Aug 30, 2017

@bpasero bpasero added the icon label Aug 30, 2017

@bpasero bpasero added this to the August 2017 milestone Aug 30, 2017

@bpasero bpasero self-assigned this Aug 30, 2017

@dominicfallows

This comment has been minimized.

dominicfallows commented Aug 31, 2017

Perhaps related to some thoughts here #issuecomment-325998918 ?

@bpasero

This comment has been minimized.

Member

bpasero commented Aug 31, 2017

Now using the macOS icon on Linux too.

@bpasero bpasero closed this Aug 31, 2017

@weinand weinand added the verified label Sep 1, 2017

@weinand weinand reopened this Sep 1, 2017

@weinand

This comment has been minimized.

Member

weinand commented Sep 1, 2017

I'm not seeing a different icon in the 9c27b11 build:
2017-09-01_11-55-48

@bpasero

This comment has been minimized.

Member

bpasero commented Sep 1, 2017

I did a bad commit, next insider to verify.

@bpasero bpasero closed this Sep 1, 2017

@bpasero bpasero closed this in 5dcbf2e Sep 1, 2017

@weinand weinand removed the verified label Sep 1, 2017

jrieken added a commit that referenced this issue Sep 1, 2017

@weinand

This comment has been minimized.

Member

weinand commented Sep 1, 2017

Nice!
2017-09-01_14-57-36

@weinand weinand added verified and removed verification-found labels Sep 1, 2017

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.