Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS Code icon is too transparent #33503

Closed
weinand opened this issue Aug 30, 2017 · 5 comments
Closed

VS Code icon is too transparent #33503

weinand opened this issue Aug 30, 2017 · 5 comments
Assignees
@bpasero @chrisdias
Labels
bug Issue identified by VS Code Team member as probable bug icon-brand VS Code brand icon issues verified Verification succeeded
Milestone
August 2017

Comments

@weinand
Copy link
Contributor

weinand commented Aug 30, 2017 •
edited
Loading

ref #33272:

On "Elementary OS (linux), the VS Code icon shows up in the dock with "sublime fragility":

2017-08-30_12-09-19
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Aug 30, 2017
@bpasero bpasero added the icon-brand VS Code brand icon issues label Aug 30, 2017
@bpasero bpasero added this to the August 2017 milestone Aug 30, 2017
@bpasero bpasero self-assigned this Aug 30, 2017
@dominicfallows
Copy link

dominicfallows commented Aug 31, 2017 •
edited
Loading

Perhaps related to some thoughts here #issuecomment-325998918 ?

@bpasero
Copy link
Member

bpasero commented Aug 31, 2017

Now using the macOS icon on Linux too.

@bpasero bpasero closed this as completed Aug 31, 2017
@weinand weinand added the verified Verification succeeded label Sep 1, 2017
@weinand weinand reopened this Sep 1, 2017
@weinand weinand added the verification-found Issue verification failed label Sep 1, 2017
@weinand
Copy link
Contributor Author

weinand commented Sep 1, 2017

I'm not seeing a different icon in the 9c27b11 build:
2017-09-01_11-55-48

@bpasero
Copy link
Member

bpasero commented Sep 1, 2017

I did a bad commit, next insider to verify.

@bpasero bpasero closed this as completed Sep 1, 2017
@bpasero bpasero closed this as completed in 5dcbf2e Sep 1, 2017
@weinand weinand removed the verified Verification succeeded label Sep 1, 2017
jrieken pushed a commit that referenced this issue Sep 1, 2017
@bpasero @jrieken
fix #33503
38c971d
@weinand
Copy link
Contributor Author

weinand commented Sep 1, 2017

Nice!
2017-09-01_14-57-36

@weinand weinand added verified Verification succeeded and removed verification-found Issue verification failed labels Sep 1, 2017
@retrixe retrixe mentioned this issue Sep 17, 2017
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

@chrisdias chrisdias

Labels
bug Issue identified by VS Code Team member as probable bug icon-brand VS Code brand icon issues verified Verification succeeded
Projects
None yet
Milestone
August 2017
Development

No branches or pull requests
4 participants
@dominicfallows @bpasero @chrisdias @weinand