-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 2.0 rc5 release #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
MiczFlor
commented
Dec 1, 2019
- What's new?
- Integrate your Phoniebox in your Smart Home.
- Smoother Web App running on ajax.
- The one-line install script handles both: Classic and +Spotify when setting up your Phoniebox.
- Control the debug logs in the web app (individual scripts switched on/off, empty log file).
- Set maximum volume with RFID cards.
The code in `inc.settingsFolderSpecific.sh` should read the value for `FOLDER` only from `Latest_Folder_Played` if it is not set by its parent script. Otherwise this might return with no value at all for example on the first media played and with wrong settings if changing playlists. fixes #514
Information and controls for the webplayer page was moved from server rendering to AJAX requests. API endpoints were added to request status informations and send commands. The Webpage can now be controlled without full page reloads so that it feels more responsive. Also the number of calls to mopidy was reduced so that the page loads faster and mopidy stability is improved.
Add new CardIDs for MAXVOLUME
…yout_controls fix: handling of FOLDER in playlistaddplay
Improve webplayer UX
Bugfix/webplayer
add new maxvolume cardids
fix typo in buster-install-default.sh
bugfix: vol80 could not be set / add maxvolcardids
fixed exec permission
- Rework "currentsong" response processing, split key-value pairs at ": " - Change all response keys to lower case for further processing - Change "playlist" command to "playlistinfo" to receive additional track info (pos, time, albumLength) - Add singlequotes to directory shell arguments to support spaces in folders - Remove comma from playlist name if exists, to fix collapsable tracklist - Remove duplicate ":" from list argument - Hide overalltime for e.g. podcasts Introduce php-unit as testing framework - Add composer as dependency manager - Add phpunit and php-mock as dependencies - Introduce namespace 'Jukebox' to enable mocking of build-in php functions e.g. "exec", "headers"
Restore missing playlist in webapp #623
Fixes also a javascript error when no playlist is present
Fix current volume is not displayed on settings page
dertobes
reviewed
Dec 11, 2019
@@ -493,6 +493,9 @@ fi | |||
cd /home/pi/ | |||
git clone https://github.com/MiczFlor/RPi-Jukebox-RFID.git | |||
|
|||
move into the Phoniebox dir |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be # move into the Phoniebox dir
#655
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.