Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tags on parallel interface when in LS discretization mode - for ParMmg #239

Merged
merged 2 commits into from
Feb 8, 2024

Conversation

laetitia-m
Copy link
Contributor

In ParMmg and in LS discretization mode, when we arrive for the second time in MMG5_bdryTria, in the surface analysis, xtetra.tag exists and tria.tag is updated using xtretra values.

In MMG5_bdryTria, the edge tags of the triangle are assigned based on what is stored in xtetra.tag. However, in parallel, th edges should not inherit:
(1) the tag PARBDYBDY here and
(2) the tags PARBDY, NOSURF and REQ when we arrive from a non-parallel faces.
The assignment of these appropriate tags is done later in MMG5_mmgHashTria

for( j = 0; j < 3; j++ ) {
/* Assign tags to tria from xtetra->tag and remove redundant boundary tag */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add some additionnal comments to illustrate the issue we found when analysing for the second time the surface intersections in ParMmg :

/* Assign tags to tria from xtetra->tag and remove redundant boundary tag: when called from ParMmg in ls mode, it is needed to remove the parallel tags coming from previous surface analysis to ensure the suitable setting of the MG_BDY tag along edges at the intersection between geometrical (true) boundaries and purely parallel interfaces. For that, it is mandatory to remove the MG_PARBDYBDY tag already added along such edges (see the step 2 of the mmgHashTria implementation) */

Copy link
Member

@Algiane Algiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Algiane Algiane merged commit 3647b34 into MmgTools:develop Feb 8, 2024
23 checks passed
@laetitia-m laetitia-m deleted the feature/pmmg-tag-fix branch February 8, 2024 15:07
laetitia-m added a commit to laetitia-m/mmg that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants