Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore MG_OLDPARBDY tag in MMG5_coltet and MMG5_coltetlag #272

Merged
merged 1 commit into from
May 17, 2024

Conversation

coprigent
Copy link
Contributor

Since pull request #241, tag MG_OLDPARBDY may be given to edges during a split. It is then necessary to ignore it to ensure the validity of if statements using integer comparaison in MMG5_coltet and MMG5_coltetlag.

…alidity of if statements using integer comparaison
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 50.48%. Comparing base (9e391f3) to head (5d45866).
Report is 1 commits behind head on develop.

Files Patch % Lines
src/mmg3d/mmg3d1.c 69.23% 1 Missing and 3 partials ⚠️
src/mmg3d/mmg3d3.c 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #272   +/-   ##
========================================
  Coverage    50.47%   50.48%           
========================================
  Files          174      174           
  Lines        47158    47167    +9     
  Branches     10259    10255    -4     
========================================
+ Hits         23802    23811    +9     
  Misses       15633    15633           
  Partials      7723     7723           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Algiane Algiane added kind: bug error or fault part: mmg3d mmg3d specific labels May 17, 2024
@Algiane Algiane merged commit 184b00b into MmgTools:develop May 17, 2024
26 checks passed
@Algiane
Copy link
Member

Algiane commented May 17, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug error or fault part: mmg3d mmg3d specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants