Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update changes how edge tags are initialized during pattern splits. Newly created edges in faces of original tetrahedra now receive tags from this face (except MG_REF tags). Tags of edges created inside original tetra are still set to zero.
The main purpose of this update is to ensure the validity of edge tags along the whole remeshing process (especially MG_BDY tags).
With this update, continuous integration tests provide altered outputs compared to previous versions of the code. This is due to the fact that, because edge tags are modified, more collapses are now allowed in the process. The following tests are in cause:
mmg/src/mmg3d/mmg3d1.c
Line 956 in b899536
Before the update, the situation where a MG_BDY point would be attempted to be merged over a non-boundary edge would be refused. After the update, some collapses are now allowed because the corresponding edge is non longer non-boundary: it now has a MG_BDY tag, leading to a valid collapse.