Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update edge tags in splits #241

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Conversation

coprigent
Copy link
Contributor

@coprigent coprigent commented Feb 2, 2024

This update changes how edge tags are initialized during pattern splits. Newly created edges in faces of original tetrahedra now receive tags from this face (except MG_REF tags). Tags of edges created inside original tetra are still set to zero.
The main purpose of this update is to ensure the validity of edge tags along the whole remeshing process (especially MG_BDY tags).
With this update, continuous integration tests provide altered outputs compared to previous versions of the code. This is due to the fact that, because edge tags are modified, more collapses are now allowed in the process. The following tests are in cause:

if ( p0->tag > tag ) continue;

Before the update, the situation where a MG_BDY point would be attempted to be merged over a non-boundary edge would be refused. After the update, some collapses are now allowed because the corresponding edge is non longer non-boundary: it now has a MG_BDY tag, leading to a valid collapse.

…, MMG5_split3op, MMG5_split4sf, MMG5_split4op, MMG5_split5, MMG5_split6, MMG5_split1b_eltspl : edges created in a face of original tetra receive tags from this face (e.g. MG_BDY for boundary entities)
@Algiane Algiane added kind: enhancement enhancement to an existing feature part: surface model specific to surface model labels Mar 5, 2024
@Algiane Algiane merged commit c51f5f4 into MmgTools:develop Mar 28, 2024
1 check passed
@Algiane
Copy link
Member

Algiane commented Mar 28, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement enhancement to an existing feature part: surface model specific to surface model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants